Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#402 closed Open task (fixed)

Either improve or abandon dynamic properties

Reported by: Matthäus Wander Owned by: Matthäus Wander
Priority: Must have Milestone: CrypTool 2.0 BETA 7
Component: General Keywords:
Cc:

Description (last modified by Matthäus Wander)

Dynamic plugin properties are seldom used, but they do exist. They are however barely tested with new WorkspaceManager and there will be most likely some issues.

Check existing use of dynamic properties. Decide whether we really need them. If yes:

  • test them thoroughly with WorkspaceManager, e.g.
    • whether internationalization correctly works on caption and tooltip of dynamic property fields (it doesn't in r3955)
    • if type really changes in WSM (e.g. TextOutput) when you change the setting
    • what happens if property is connected and you switch type
    • what happens if property is connected and workspace is playing and you switch type
    • ...
  • think about how to improve interface practicability and how to make dynamic properties more robust
  • ????
  • profit

If no:

  • Remove dynamic properties from IPlugin interface
  • Find and adapt plugins which use dynamic properties (BooleanFunctionParser, Concatenate, Mux, TextOutput)

Change History (12)

comment:1 Changed 10 years ago by Matthäus Wander

Dynamic properties are used by:

  • BooleanFunctionParser
  • Concatenate
  • Mux
  • TextOutput

comment:2 Changed 10 years ago by Matthäus Wander

Owner: changed from coredevs to Matthäus Wander
Status: newassigned

comment:3 Changed 10 years ago by Matthäus Wander

Description: modified (diff)

comment:4 Changed 10 years ago by Matthäus Wander

Description: modified (diff)

comment:5 Changed 10 years ago by Matthäus Wander

(In [4121]) * removed dynamic properties from TextOutput (refs #402)

comment:6 Changed 10 years ago by Matthäus Wander

Description: modified (diff)

comment:7 Changed 10 years ago by Matthäus Wander

(In [4123]) Removed Multiplexer component, use Gate instead (refs #402)

comment:8 Changed 10 years ago by Matthäus Wander

Description: modified (diff)

comment:9 Changed 10 years ago by Matthäus Wander

(In [4126]) Removed dynamic properties from BooleanFunctionParser (refs #402)

Please note: this seems to be the only plugin which suffers a functional degradation with static data properties. However, I can't really estimate the impact as there is no template which uses the input props (there's an IControl one but this is unaffected by my change). Without a template I also cannot test whether everything's still working. If multiple input props are needed, I suggest to add more static properties and implement a "hide property mechanism" which should allow for the advantages of displaying a variable number of inputs but without the complexity (leading to various failures) of dynamic properties.

comment:10 Changed 10 years ago by Matthäus Wander

Description: modified (diff)

comment:11 Changed 10 years ago by Matthäus Wander

Resolution: fixed
Status: assignedclosed

(In [4130]) cleanup:

  • removed dynamic properties (closes #402)
  • removed rudiments of obsolete XAML description
  • removed unused IEditor.ShowHelp() and IEditor.Active() declarations

comment:12 Changed 10 years ago by Matthäus Wander

Milestone: CrypTool 2.0 RELEASECrypTool 2.0 BETA 7
Note: See TracTickets for help on using tickets.