Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#17 closed Feature request (fixed)

Website link to current setup should be changeable by SVN commit for the coredevs

Reported by: Thomas Schmid Owned by: Sören Rinne
Priority: Should be done Milestone:
Component: General Keywords:
Cc:

Description

Since SVN in combination with trac supports public links to files, it would be nice to have the chance to update the link by SVN commit. Maybe it could be done with some website include file for the download page.

Change History (18)

comment:1 Changed 13 years ago by Sören Rinne

Status: newaccepted

comment:2 Changed 13 years ago by Sören Rinne

Can you show me how this "public link" works?

comment:3 Changed 13 years ago by Thomas Schmid

Of course: You can browse the source. Maybe go to: https://www.cryptool.org/trac/CrypTool2/browser/trunk/CrypCurrentVersionDownload/Cryptool-Setup-v2.0.3236a(beta).msi

There you'll find a link to direct download the file: https://www.cryptool.org/trac/CrypTool2/export/27/trunk/CrypCurrentVersionDownload/Cryptool-Setup-v2.0.3236a%28beta%29.msi

This should work for every file. My idea was to upload the new setup file and put this direct download link into a file and commit it as well. This file should be included in the setup section of the homepage. Do you think this is possible?

comment:4 Changed 13 years ago by Sören Rinne

This should work. In php I just can include a file at any position in the source code. So, could you please check in a file with just the URL like you mentioned above?

Another question: is the version in the filename always the same length? So that one can say that the version number are the last 15 character + .msi? If not, it shouldn't be a problem anyway thanks to regular expressions ;) (assuming at that at least the phrase "Cryptool-Setup-" remains the same).

comment:5 Changed 13 years ago by Arno Wacker

Priority: ShowstopperShould be done

comment:7 Changed 13 years ago by Arno Wacker

Including the information from the provided file would only give you a direct link to the download, but not provide an information directly visible for the user.

Maybe if we put two thinks in this file e.g. like version=2.0.x.y url=https://....

With this information, maybe Sören could get this file in php directly from svn, and interpret each line, i.e. generate dynamic html code. Alternatively I could also create a cronjob, which puts this special file into any place of the filesystem of the server (similar like we provided doanload until now). Just my two cents.. :)

comment:8 Changed 13 years ago by Thomas Schmid

Thanks for the idea :-) I have updated the file...

comment:9 Changed 13 years ago by Arno Wacker

(In [68]) - This refs #17 and should be appended. Keep geeting strange post-commit errors..

comment:10 Changed 13 years ago by Arno Wacker

(In [69]) - Removed test-file again. Now referencing tickets seems to work. This refs #17

comment:11 in reply to:  10 Changed 13 years ago by Sören Rinne

Encountered a problem. The link to a file in the SVN includes the revision: https://www.cryptool.org/trac/CrypTool2/export/'''81'''/trunk/CrypCurrentVersionDownload/direct_download.txt

It's no problem when using this kind of link with the msi-file, but it is a problem when trying to get the current direct_download.txt-file. Because I need to know the current revision first, to get the newest direct_download.txt

Any solutions for this?

comment:12 Changed 13 years ago by Arno Wacker

comment:13 Changed 13 years ago by Sören Rinne

Another problem:

When I try to open the .txt-file with php

$config_file = 'https://www.cryptool.org/trac/CrypTool2/browser/trunk/CrypCurrentVersionDownload/direct_download.txt?format=txt';
$fp = fopen($config_file, "r");

I get an error. Maybe it's a problem with trac, because it does not return the file properly. In my Firefox it doesn't open the file, it prompts me to download it. Same with IE.

And same with the ?format=txt link.

comment:14 Changed 13 years ago by Sören Rinne

Or maybe it's a server-side setting:

http://de3.php.net/manual/de/features.remote-files.php

comment:15 Changed 13 years ago by Sören Rinne

Resolution: fixed
Status: acceptedclosed

Done. For any new version please change the CurrentVersion.txt The actual link is generated by putting the version from the file inside the link, so please leave the name always the same:

http://cryptool2.vs.uni-due.de/downloads/program/curversion/Cryptool-Setup-v' . $config_valuesversion? . '.msi

Disadvantage: gets updated only on a daily basis.

comment:16 Changed 13 years ago by Arno Wacker

(In [88]) Removed direct_download.txt, since it is not needed anymore, see #17

comment:17 Changed 13 years ago by Arno Wacker

Suggestion:

How about that the Dowload button in the upper right corner (the one which is always visible) should read "Download CrypTool 2.0.x.y" and linking directly to the current version (not the repository as it is right now). If you go on the "real" download page, you might link to the repository, because there you might find also older versions. Hence on the Download page it would then read:

Here you can download the current and older version of CrypTool 2.0:

  • CrypTool 2.0.3236a(beta) - download -> this link pointing to current version (as it is)
  • All downloads -> this link pointing to the trac (this would be new)

Just an idea..

comment:18 Changed 13 years ago by Sören Rinne

Suggestion accepted and implemented.

Note: See TracTickets for help on using tickets.